[icedtea-web] RFC: Minor fixes to ALACA dialog

Jacob Wisor gitne at gmx.de
Tue Apr 1 12:20:51 UTC 2014


On 03/31/2014 06:26 PM, Omair Majid wrote:
> * Jiri Vanek <jvanek at redhat.com> [2014-03-31 09:54]:
>> Yes. This is ok to go. Also I'm for the compression  of  info
>> attribute. I think it is more wide spread. Then jsut in alaca.
>
> There is one other link with full link text: MissingPermissionsInfo. The
> attached patch fixes that.
 >
 > diff --git a/netx/net/sourceforge/jnlp/resources/Messages.properties b/netx
 > /net/sourceforge/jnlp/resources/Messages.properties
 > --- a/netx/net/sourceforge/jnlp/resources/Messages.properties
 > +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties
 > @@ -56,9 +56,9 @@
 >  Applications without this attribute should not be trusted. Do you wish to
 >  allow this application to run?
 >  MissingPermissionsInfo=For more information you can visit:<br/>\
 >  <a href="http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/security
 > /manifest.html#permissions"> \

Don't you want to escape those href attribute's quotes (") with a backslash (\)? 
I am afraid the property file loader will get confused.
And, that number sign character (#) should probably be escaped too so it doesn't 
get interpreted as a comment escape. I have not tested it yet, but this may also 
get the property file loader confused.

 > -http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/security
 > /manifest.html#permissions</a> <br/> \
 > +JAR File Manifest Attributes</a> <br/> \
 >  and<br/> <a href="http://docs.oracle.com/javase/7/docs/technotes/guides
 > /jweb/security/no_redeploy.html"> \
 > -http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/security
 > /no_redeploy.html</a>
 > +Preventing the repurposing of Applications</a>

Same goes here.

Jacob


More information about the distro-pkg-dev mailing list