[rfc][icedtea-web] offline support

[Andrew Azores]

On 08/04/2014 11:34 AM, Jiri Vanek wrote:
> +    public static boolean isOnline() {
> +        if (isOfflineForced()) {
> +            return !isOfflineForced();
> +        }
> +        return onlineDetected;
> +    }

This hunk is a little bit silly IMO :) that first return can just be 
"return false".

I'm also not a fan (and I'm sure you're not surprised here) of 
onlineDetected being a Boolean, but since the null value is only ever 
used in internal state and all the outward facing accessors use plain 
boolean, I guess it's okay.

Otherwise... I can't find much else to complain about. It seems to work 
fine and I generally like the patch. There is one thing I'm wondering 
about though. Using this patch with a large application (in this case 
Elluminate), the application still takes quite some time to start up. Is 
this simply because of how many local JARs there are to verify? Or maybe 
ResourceTracker is still sending HEAD requests to try to check if the 
JARs are up to date... ?

Thanks,

-- 
Andrew A