[rfc][icedtea-web] CacheUtil Clear Cache Small Fix
Omair Majid
omajid at redhat.com
Fri Aug 29 20:51:40 UTC 2014
* Jie Kang <jkang at redhat.com> [2014-08-29 12:02]:
> This patch fixes this issue by also clearing the LRU when clearing the
> cache.
That seems sensible.
> I have also renamed the function to emptyCache in order to
> clash less with the function cleanCache (which removes files marked
> for delete, not all files) Thoughts?
This one, I am less sure about. The CacheLRUWrapper also contains a
clear method, so at least the current convention is a little bit
consistent.
Also, I am a bit surprised that the patch does not touch any caller.
Does no code in icedtea-web actually call this method?
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the distro-pkg-dev
mailing list