[rfc][icedtea-web] CacheUtil Clear Cache Small Fix

Jie Kang jkang at redhat.com
Fri Aug 29 21:03:09 UTC 2014

----- Original Message -----
> * Jie Kang <jkang at redhat.com> [2014-08-29 12:02]:
> > This patch fixes this issue by also clearing the LRU when clearing the
> > cache.
> That seems sensible.
> > I have also renamed the function to emptyCache in order to
> > clash less with the function cleanCache (which removes files marked
> > for delete, not all files) Thoughts?
> This one, I am less sure about. The CacheLRUWrapper also contains a
> clear method, so at least the current convention is a little bit
> consistent.


True. Okay without the rename then?

> Also, I am a bit surprised that the patch does not touch any caller.
> Does no code in icedtea-web actually call this method?

Oh gosh, my bad. Working in a repo with multiple changes for different patches and I didn't diff any of the other files that changed thinking that this was the only one that was relevant. However without the rename it's just one file now :D


> Thanks,
> Omair
> --
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


Jie Kang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-cacheutil-clearcache.patch
Type: text/x-patch
Size: 812 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140829/21f3ef41/itw-cacheutil-clearcache.patch>

More information about the distro-pkg-dev mailing list