[rfc][icedtea-web] Move all security dialogues' panels implementation into separate subpackage.

Jiri Vanek jvanek at redhat.com
Wed Feb 26 05:59:08 PST 2014


Move all security dialogues' panels implementation into separate subpackage.

The dialogues are really multiplying, and the package of net/sourceforge/jnlp/security/ is overrun.
This refactoring is moving all implementations of security dialogues' panels into 
net/sourceforge/jnlp/security/dialogues/

The only real change of code is


-    protected void setValue(Object value) {
+    public void setValue(Object value) {
          OutputController.getLogger().log("Setting value:" + value);
          this.value = value;
      }

in netx/net/sourceforge/jnlp/security/SecurityDialog.java

Which seems tome better then move netx/net/sourceforge/jnlp/security/SecurityDialog.java to 
netx/net/sourceforge/jnlp/security/dialogues/SecurityDialog.java

If somebody cares, this patch is applicable also to 1.4 but backports to Panes are not common. Is 
anybody for/against the refactoring of 1.4 too?

Best regards from CZ
   J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: moveAllSecurityDialoguesIntoSubpackage.git.diff
Type: text/x-patch
Size: 14687 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140226/1d12cf1c/moveAllSecurityDialoguesIntoSubpackage.git-0001.diff 


More information about the distro-pkg-dev mailing list