[rfc][icedtea-web][policyeditor] "File - New"

Lukasz Dracz ldracz at redhat.com
Wed Jul 30 19:43:42 UTC 2014


> Hi,

Hello,
 
> This patch adds "File - New" functionality to PolicyEditor, so a new
> policy file can be created/edited properly. Previously the editor would
> either have to be relaunched, or the current file could be saved and
> then the contents changed for the new file and "Save As" used to put it
> in the correct location.
> 
> This patch also makes the window title dynamic, so that it shows the
> currently open file's path (if any), and also an asterisk if any changes
> have been made in the editor since the file was opened or last saved.

Looks good +1. On an unrelated note, I noticed that Add new the second word is not capitalized but in other usages such as Save As or Custom Permissions, the second word starts with a capital, so perhaps the new should be capital too and possibly Copy Url to clipboard, the clipboard could also be capitalized. 

>From your patch, the way you handled the title is great.

-        performingIO = true;
+        setPerformingIO(true);
Good catch to use the method instead.
Anyways looks good and works well.

> Andrew A

Thank you,
Lukasz Dracz


More information about the distro-pkg-dev mailing list