[rfc][icedtea-web][policyeditor] "File - New"

[Jie Kang]

Hello,

> Hi,
> 
> This patch adds "File - New" functionality to PolicyEditor, so a new
> policy file can be created/edited properly. Previously the editor would
> either have to be relaunched, or the current file could be saved and
> then the contents changed for the new file and "Save As" used to put it
> in the correct location.
> 

I would add ellipses to the other names that open new dialogs. E.g. 'Open...', the ellipses could also be applied to 'Add new'., etc.


> This patch also makes the window title dynamic, so that it shows the
> currently open file's path (if any), and also an asterisk if any changes
> have been made in the editor since the file was opened or last saved.

Nice :D

>From my testing, removing a codebase doesn't cause changesMade to be set to true. e.g. add codebase, save, remove codebase : state should be changesMade=true, but no * is shown in UI.


I notice that if you check something permission it will be set to * to show changes made, but if you uncheck it, it remains as *. This functionality differs from other programs I think. This is probably because the change-checking mechanism doesn't save the base-state and compare with it to see changes made. Maybe for a future patch this could be implemented.




> 
> Thanks,
> 
> --
> Andrew A
> 
> 

Regards,


-- 

Jie Kang