[rfc][icedtea-web] PluginMessage test time zone

[Andrew Azores]

It's surprising to me that this works with TEST_TIME being only given a value in the @BeforeClass, but used already to define the s1/s2/s3 fields as well. It does appear to work fine but at first glance this to me is not obvious at all that it is correct. I would be more comfortable with it if the fields s1/s2/s3 were defined as fields but not given their values in the @BeforeClass as well, after TEST_TIME has already been set. Then it is much more obvious IMO that the fields have the correct values that they should. Otherwise, looks good. One other thing would be to make s1/s2/s3 private.

Alternatively, instead of @BeforeClass, you can probably use a static initializer instead. This would also allow s1/s2/s3 to be made static final, aka actual constants.

Thanks,

Andrew A

----- Original Message -----
> 
> 
> ----- Original Message -----
> > From: "Omair Majid" <omajid at redhat.com>
> > To: "Lukasz Dracz" <ldracz at redhat.com>
> > Cc: distro-pkg-dev at openjdk.java.net
> > Sent: Tuesday, June 3, 2014 10:41:44 AM
> > Subject: Re: [rfc][icedtea-web] PluginMessage test time zone
> > 
> > 
> > An alternative is to explicitly set (and then restore) the locale using
> > Locale.setDefault() in a @Before (and restore in an @After) method. This
> > ensures the test always sees the same locale, irrespective of the system
> > locale. If you are dealing with timestamps, this is often an easier
> > approach to use.
> > 
> 
> Thank you for your suggestion, I have looked into this and implemented it in
> this way.
> 
> > > +++
> > > b/tests/netx/unit/net/sourceforge/jnlp/util/logging/JavaConsoleTest.java
> > > 	Tue Jun 03 10:18:24 2014 -0400
> > 
> > > +        Date localized = new Date();
> > > +        localized.setTime(new SimpleDateFormat("EEE MMM dd HH:mm:ss ZZZ
> > > yyyy").parse(TEST_TIME).getTime());
> > 
> > Why not just:
> > 
> >      Date localized = new SimpleDateFormat(...).parse(...)
> > 
> 
> You're right that is better way.
> 
> > Thanks,
> > Omair
> > 
> > --
> > PGP Key: 66484681 (http://pgp.mit.edu/)
> > Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
> > 
> 
> I have attached the updated patch.
> 
> Thank you,
> Lukasz Dracz