[rfc][icedtea-web][policyeditor] Copy/Paste/Rename extracted and unit tests added

Jie Kang jkang at redhat.com
Thu Jun 5 20:43:46 UTC 2014


Hello

----- Original Message -----
> Hi,
> 
> This patch extracts the Copy/Paste/Rename codebase actions into their
> own methods, which the button ActionListeners now call. This allows for
> better code reusability (including Rename now being implemented as a
> copy/paste and remove), and also means tests can be easily added, which
> they have been.
> 

Everything still works. I suggest changing rename a little to make it select the newly renamed codebase. Looks fine.

> Also, this patch makes it so that copy/paste includes custom
> permissions, not only "editor permissions" (the ones with checkboxes).
> 
> Thanks,
> 
> --
> Andrew A
> 
> 

Regards

Jie Kang


More information about the distro-pkg-dev mailing list