[rfc][icedtea-web][policyeditor] Copy/Paste/Rename extracted and unit tests added

Lukasz Dracz ldracz at redhat.com
Thu Jun 5 21:02:41 UTC 2014



----- Original Message -----
> From: "Andrew Azores" <aazores at redhat.com>
> To: "IcedTea" <distro-pkg-dev at openjdk.java.net>
> Sent: Thursday, June 5, 2014 4:09:21 PM
> Subject: [rfc][icedtea-web][policyeditor] Copy/Paste/Rename extracted and	unit tests added
> 
> Hi,
> 
> This patch extracts the Copy/Paste/Rename codebase actions into their
> own methods, which the button ActionListeners now call. This allows for
> better code reusability (including Rename now being implemented as a
> copy/paste and remove), and also means tests can be easily added, which
> they have been.
> 
> Also, this patch makes it so that copy/paste includes custom
> permissions, not only "editor permissions" (the ones with checkboxes).
> 
> Thanks,
> 
> --
> Andrew A
> 
> 
Hello,

Looks good to me , +0.5 ! 

Thank you,
Lukasz Dracz


More information about the distro-pkg-dev mailing list