[rfc][icedtea-web][policyeditor] Reduced usage of weak references

[Andrew Azores]

On 06/11/2014 09:47 AM, Andrew Azores wrote:
> On 06/02/2014 10:27 AM, Andrew Azores wrote:
>> Hi,
>>
>> This patch reduces the usage of weak references in PolicyEditor and 
>> CustomPolicyViewer. There is still one use of a weak reference left, 
>> used when closing PolicyEditor and answering 'Yes' to saving changes 
>> first. In this case, the "Changes Saved" dialog appears after the 
>> editor has been closed and disposed, but the dialog holds a reference 
>> to it. This results in the JVM not exiting after PolicyEditor is 
>> closed. Using the weak reference in the way it's still used here 
>> allows for the JVM to properly exit once the editor is closed, while 
>> still allowing the dialog to be modal when it is shown in situations 
>> where the editor is not already closed.
>>
>> ChangeLog:
>> * 
>> netx/net/sourceforge/jnlp/security/policyeditor/CustomPolicyViewer.java
>> (weakThis): removed
>> * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java
>> (weakThis): used only in showChangesSavedDialog, other uses changed 
>> to PolicyEditor.this
>>
>> Thanks,
>>
>
> Ping.
>
> Thanks,
>

Here's a new version of the patch that applies cleanly on current HEAD.

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: policyeditor-weakthis-3.patch
Type: text/x-patch
Size: 11937 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140611/50b80185/policyeditor-weakthis-3.patch>