[rfc][icedtea-web][policyeditor] Keyboard shortcuts and mnemonics touchup

[Omair Majid]

Hi,

* Andrew Azores <aazores at redhat.com> [2014-06-26 15:17]:
> 1) Pressing "Enter" while a Group Checkbox has focus will expand the group
> (pressing space still selects the entire group at once)

This change seems fine to me, but I am not sure how discoverable it is.
Maybe a little expand/contract widget that looks like a '+' to
expand/collapse might be simpler?

> 2) Every menu item now has an accelerator shortcut and they all actually
> work properly

They look good.

> 3) Accelerator shortcuts are more sane/intuitive

:)

> 4) Defining shortcut keys in Messages.properties is simpler (! This one
> requires help from translators to fix the key bindings. It's also not
> entirely ideal because the modifier masks are not configurable via
> Messages.properties right now either - anyone have ideas on how to do that
> more neatly than having the Messages actually specify eg "C-S" or "C-S-S"
> for Ctrl-S/Ctrl-Shift-S per shortcut, for example? This wouldn't really be
> so bad though, I guess, especially since these strings would be defined
> solely by the person writing the translations, and never input by users)

If you really want the shortcuts to be customizable for different
localizations, I am not sure there's another way. A simple descriptor
like 'C-' and 'S-' is probably the closest you can get. Emacs does
something like this, where users define keybindings using strings
exactly like this.

One unrelated nit: In the "Edit" menu, all items except one mention the
word codebase. The item that doesn't mention codebase still works with
codebases. Have you thought about renaming the "Edit" menu to "Codebase"
and changing the multi-word drescriptions (like "Copy Codebase") to
one-word descriptions (like "Copy")?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681