[rfc][icedtea-web][policyeditor] Keyboard shortcuts and mnemonics touchup

[Jie Kang]

Hello,


> Hi,
> 
> This patch enhances PolicyEditor's accessibility quite a lot. Changes
> include:
> 
> 1) Pressing "Enter" while a Group Checkbox has focus will expand the
> group (pressing space still selects the entire group at once)
> 2) Every menu item now has an accelerator shortcut and they all actually
> work properly
> 3) Accelerator shortcuts are more sane/intuitive

Basic user testing and it all looks good. + 0.5


> 4) Defining shortcut keys in Messages.properties is simpler (! This one
> requires help from translators to fix the key bindings. It's also not
> entirely ideal because the modifier masks are not configurable via
> Messages.properties right now either - anyone have ideas on how to do
> that more neatly than having the Messages actually specify eg "C-S" or
> "C-S-S" for Ctrl-S/Ctrl-Shift-S per shortcut, for example? This wouldn't
> really be so bad though, I guess, especially since these strings would
> be defined solely by the person writing the translations, and never
> input by users)

I think having complete specs such as C-S-S is an acceptable solution. Given that the options need to be entirely customizable there's not much else you can do.


> 
> Coming up later will be accelerators/mnemonics for CustomPolicyViewer.
> 
> Thanks,
> 
> --
> Andrew A
> 
> 

-- 

Jie Kang