[rfc][icedtea-web][policyeditor] Keyboard shortcuts and mnemonics touchup

[Andrew Azores]

On 06/26/2014 03:16 PM, Andrew Azores wrote:
> Hi,
>
> This patch enhances PolicyEditor's accessibility quite a lot. Changes 
> include:
>
> 1) Pressing "Enter" while a Group Checkbox has focus will expand the 
> group (pressing space still selects the entire group at once)
> 2) Every menu item now has an accelerator shortcut and they all 
> actually work properly
> 3) Accelerator shortcuts are more sane/intuitive
> 4) Defining shortcut keys in Messages.properties is simpler (! This 
> one requires help from translators to fix the key bindings. It's also 
> not entirely ideal because the modifier masks are not configurable via 
> Messages.properties right now either - anyone have ideas on how to do 
> that more neatly than having the Messages actually specify eg "C-S" or 
> "C-S-S" for Ctrl-S/Ctrl-Shift-S per shortcut, for example? This 
> wouldn't really be so bad though, I guess, especially since these 
> strings would be defined solely by the person writing the 
> translations, and never input by users)
>
> Coming up later will be accelerators/mnemonics for CustomPolicyViewer.
>
> Thanks,
>

Here's round two of the patch, taking into account the helpful input 
from Omair and Jacob. Difference from last patch:

1) Mnemonics and accelerators are separated in Messages.properties
2) KeyStroke.getKeyStroke is used, so accelerators are fully defined in 
Messages.properties, including modifier keys
3) The Edit menu has been renamed Codebase, and menu items have have 
"codebase" removed from their labels
4) Some mnemonics tweaked to be a little more convenient
5) "Copy URL to codebase" is control shift c rather than control b

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: policyeditor-keybindings-2.patch
Type: text/x-patch
Size: 21893 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140627/afdff9ff/policyeditor-keybindings-2.patch>