[rfc][icedtea-web] Trusted-only manifest attribute
Jiri Vanek
jvanek at redhat.com
Fri Mar 21 15:27:12 UTC 2014
On 03/21/2014 03:56 PM, Omair Majid wrote:
> * Andrew Azores <aazores at redhat.com> [2014-03-20 11:35]:
>> +++ b/netx/net/sourceforge/jnlp/runtime/ManifestsAttributesValidator.java
>
>> + void checkTrustedOnlyAttribute() throws LaunchException {
>
> A stylistic nit: if you ask me to use a class named *Validator, I will
> look for the validate* method as the first thing. If the class is named
> *Checker, then maybe a check* method makes more sense.
>
> What do you think?
>
> Thanks,
> Omair
>
the small refactoring
ManifestsAttributesValidator -> ManifestsAttributesChecker
and all its current methods started with check
is probably worthy to do...
J.
More information about the distro-pkg-dev
mailing list