[rfc][icedtea-web] Trusted-only manifest attribute

Andrew Azores aazores at redhat.com
Mon Mar 24 13:07:28 UTC 2014


On 03/21/2014 11:27 AM, Jiri Vanek wrote:
> On 03/21/2014 03:56 PM, Omair Majid wrote:
>> * Andrew Azores <aazores at redhat.com> [2014-03-20 11:35]:
>>> +++ 
>>> b/netx/net/sourceforge/jnlp/runtime/ManifestsAttributesValidator.java
>>
>>> +    void checkTrustedOnlyAttribute() throws LaunchException {
>>
>> A stylistic nit: if you ask me to use a class named *Validator, I will
>> look for the validate* method as the first thing. If the class is named
>> *Checker, then maybe a check* method makes more sense.
>>
>> What do you think?
>>
>> Thanks,
>> Omair
>>
>
>
> the small refactoring
>
> ManifestsAttributesValidator -> ManifestsAttributesChecker
>
> and all its current methods started with check
>
> is probably worthy to do...
>
> J.

Just this?

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: manifest-attributes-checker-rename.patch
Type: text/x-patch
Size: 31708 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140324/82de6378/manifest-attributes-checker-rename-0001.patch>


More information about the distro-pkg-dev mailing list