[rfc][icedtea-web] Trusted-only manifest attribute

[Jiri Vanek]

On 03/24/2014 02:07 PM, Andrew Azores wrote:
> On 03/21/2014 11:27 AM, Jiri Vanek wrote:
>> On 03/21/2014 03:56 PM, Omair Majid wrote:
>>> * Andrew Azores <aazores at redhat.com> [2014-03-20 11:35]:
>>>> +++ b/netx/net/sourceforge/jnlp/runtime/ManifestsAttributesValidator.java
>>>
>>>> +    void checkTrustedOnlyAttribute() throws LaunchException {
>>>
>>> A stylistic nit: if you ask me to use a class named *Validator, I will
>>> look for the validate* method as the first thing. If the class is named
>>> *Checker, then maybe a check* method makes more sense.
>>>
>>> What do you think?
>>>
>>> Thanks,
>>> Omair
>>>
>>
>>
>> the small refactoring
>>
>> ManifestsAttributesValidator -> ManifestsAttributesChecker
>>
>> and all its current methods started with check
>>
>> is probably worthy to do...
>>
>> J.
>
> Just this?

Yes :)


Whn you are in, I.m for making all

checkTrustedOnlyAttribute();
checkCodebaseAttribute();
checkPermissionsAttribute();
checkApplicationLibraryAllowableCodebaseAttribute();

private

and encapsulate them in public checkAll(). And call this in constructor.

If you agree feel free to encapsualte in this push. Otherwise ok to go anyway.


J,.