[icedtea-web] RFC: Reduce URLConnection knowledge in CacheEntry

[Andrew Azores]

On 05/12/2014 09:51 AM, Omair Majid wrote:
> * Omair Majid <omajid at redhat.com> [2014-05-02 13:24]:
>> I had to work on CacheEntry for a few fixes (I will be posting those
>> later) and the class seems to be doing a bit too much. The knowledge of
>> URLConnection is especially troubling, since the metadata for a
>> CacheEntry doesn't really match the URL in the presence of compression.
>>
>> The attached patch tries to reduce how much CacheEntry knows about
>> URLConnection.
> Since the other reviews asked for more unit tests, I have updated this
> patch to add even more. Most of the functionality in CacheEntry should
> now be covered by unit tests. Some of the corner cases are not, sadly.
>
> Thanks,
> Omair
>

Code looks good. Only question about the tests - why @Before rather than 
@BeforeClass for setup()? As far as I can tell, those two fields only 
need to be set once. Otherwise, looks good too.

OK to push once @Before is replaced with @BeforeClass (or if @Before is 
required and I just don't see it).

Thanks,

-- 
Andrew A