[icedtea-web] RFC: Reduce URLConnection knowledge in CacheEntry

Omair Majid omajid at redhat.com
Mon May 12 15:14:14 UTC 2014


* Andrew Azores <aazores at redhat.com> [2014-05-12 11:07]:
> Code looks good. Only question about the tests - why @Before rather than
> @BeforeClass for setup()? As far as I can tell, those two fields only need
> to be set once.

That's right. I just have a habit of re-initializing as much of the
state as possible, to avoid an accidentally broken test breaking things
for other tests. I normally try and use @BeforeClass only for things
that must be initialized once or are really expensive to initialize. To
me, @BeforeClass indicates a departure from the ideal test process which
is @Before, @Test, @After.

Anyway, I can change this if you insist.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the distro-pkg-dev mailing list