[icedtea-web] RFC: Reduce URLConnection knowledge in CacheEntry

[Andrew Azores]

On 05/12/2014 11:14 AM, Omair Majid wrote:
> * Andrew Azores <aazores at redhat.com> [2014-05-12 11:07]:
>> Code looks good. Only question about the tests - why @Before rather than
>> @BeforeClass for setup()? As far as I can tell, those two fields only need
>> to be set once.
> That's right. I just have a habit of re-initializing as much of the
> state as possible, to avoid an accidentally broken test breaking things
> for other tests. I normally try and use @BeforeClass only for things
> that must be initialized once or are really expensive to initialize. To
> me, @BeforeClass indicates a departure from the ideal test process which
> is @Before, @Test, @After.
>
> Anyway, I can change this if you insist.
>
> Thanks,
> Omair
>

Okay, fair enough. I don't insist, go on and push.

Thanks,

-- 
Andrew A