[rfc][icedtea-web] Policy Editor PR 1776 Bug Fix

Andrew Azores aazores at redhat.com
Tue May 20 20:13:49 UTC 2014


On 05/20/2014 03:56 PM, Lukasz Dracz wrote:
> Hello,
>
> Fixed the bug PR 1776 http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1776 for Policy Editor by adding a check for map being null.
> Found a bug where adding a codebase, then removing it, and adding it again would not be added. Andrew Azores fixed it by removing Custom Permissions Map from the codebase when removeCodebase is called.
>
> Thank you,
> Lukasz Dracz
>
> 2014-05-20  Lukasz Dracz  <ldracz at redhat.com>
> 	
> 	* netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java:
> 	Bug fixes, Added a check for map being null

The patch doesn't appear to actually fix PR1776, or perhaps it fixes the 
original stack trace, but there's still an exception that appears. 
Anyway, it's a good check to add, because null definitely can be passed 
in to setState if updateCheckboxesImpl is called with a String codebase 
argument that does not correspond to any existing codebases.

Please give a more descriptive ChangeLog though. "Bug fixes" doesn't 
help much :)

Thanks,

-- 
Andrew A



More information about the distro-pkg-dev mailing list