[rfc][icedtea-web] Policy Editor PR 1776 Bug Fix

[Lukasz Dracz]

----- Original Message -----
From: "Andrew Azores" <aazores at redhat.com>
To: "Lukasz Dracz" <ldracz at redhat.com>, distro-pkg-dev at openjdk.java.net
Sent: Tuesday, May 20, 2014 4:13:49 PM
Subject: Re: [rfc][icedtea-web] Policy Editor PR 1776 Bug Fix

On 05/20/2014 03:56 PM, Lukasz Dracz wrote:
> Hello,
>
> Fixed the bug PR 1776 http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1776 for Policy Editor by adding a check for map being null.
> Found a bug where adding a codebase, then removing it, and adding it again would not be added. Andrew Azores fixed it by removing Custom Permissions Map from the codebase when removeCodebase is called.
>
> Thank you,
> Lukasz Dracz
>
> 2014-05-20  Lukasz Dracz  <ldracz at redhat.com>
> 	
> 	* netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java:
> 	Bug fixes, Added a check for map being null
>
>The patch doesn't appear to actually fix PR1776, or perhaps it fixes the 
>original stack trace, but there's still an exception that appears. 
>Anyway, it's a good check to add, because null definitely can be passed 
>in to setState if updateCheckboxesImpl is called with a String codebase 
>argument that does not correspond to any existing codebases.
>
>Please give a more descriptive ChangeLog though. "Bug fixes" doesn't 
>help much :)
>
>Thanks,
>
>-- 
>Andrew A

Hello,

I updated the changelog to be more descriptive and credited Andrew Azores in the patch which I forgot to do originally. Sorry. 
I will look into fully fixing the bug.

Thank you,
Lukasz Dracz 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2014-05-20-P2-PR-1776-Bug-Fix.patch
Type: text/x-patch
Size: 1485 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140520/28d0521b/2014-05-20-P2-PR-1776-Bug-Fix.patch>