[rfc][icedtea-web] PolicyEditor Save As Changes

[Jie Kang]

Hi,

Reproduction steps as follows:

Save as Bug:
Open PolicyEditor.
Check four permissions for 'All Applet'
Save as 'abc'
Save as 'def' : this fails to work

Saving with on-disk modification Bug:
Open PolicyEditor
Check four permissions for 'All Applet'
Save as 'abc'
Delete 'abc' from disk
Save as 'abc' : this fails to work

Regards,


----- Original Message -----
From: "Andrew Azores" <aazores at redhat.com>
To: "Jie Kang" <jkang at redhat.com>, distro-pkg-dev at openjdk.java.net
Sent: Wednesday, May 21, 2014 4:42:55 PM
Subject: Re: [rfc][icedtea-web] PolicyEditor Save As Changes

On 05/21/2014 04:30 PM, Andrew Azores wrote:
> On 05/21/2014 03:32 PM, Jie Kang wrote:
>> Hi,
>>
>> Fixed the PolicyEditor's save function, allowing for appropriate 
>> saving with respect to file (on-disk) modification and user (in-app) 
>> changes. Previously one could not Save As to a new file without any 
>> in-app changes. Also previously, one could not save changes to a 
>> deleted file properly when no in-app changes were present. These 
>> issues are both addressed.
>>
>> Also removed unused imports in MD5SumWatcher.java.
>>
>>
>> 2014-05-20  Jie Kang  <jkang at redhat.com>
>>
>>      * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java
>>      (saveAsButtonAction): set changesMade to true to allow 
>> savePolicyFile to save
>>      (savePolicyFile): no longer immediately returns if changesMade 
>> is false
>>      (updateMd5WithDialog): use changesMade along with file MD5 sum 
>> changes to determine
>>      whether to continue saving to disk, also privatized method and 
>> renamed method
>>      to checkPolicyChangesWithDialog
>>      * netx/net/sourceforge/jnlp/util/MD5SumWatcher.java
>>      Removed unused imports.
>>
>> Thanks,
>
> Can you give reproduction steps please? Both things you describe 
> appear to work for me without your patch applied.
>
> Thanks,
>

Ah nevermind sorry, I seem to have some weird build stuff going on. With 
a freshly cloned copy of ITW I can reproduce the issues, even though my 
other copy claims to be up to date and clean :/ seems somehow I have a 
patch applied and mercurial doesn't think I do maybe...

Still, reproduction steps please! :)

Thanks,

-- 
Andrew A