[rfc][icedtea-web] PolicyEditor Save As Changes

[Andrew Azores]

On 05/22/2014 09:23 AM, Jie Kang wrote:
> Hi,
>
> Reproduction steps as follows:
>
> Save as Bug:
> Open PolicyEditor.
> Check four permissions for 'All Applet'
> Save as 'abc'
> Save as 'def' : this fails to work
>
> Saving with on-disk modification Bug:
> Open PolicyEditor
> Check four permissions for 'All Applet'
> Save as 'abc'
> Delete 'abc' from disk
> Save as 'abc' : this fails to work
>
> Regards,
>

Thank you! I was able to confirm the flawed behaviour and that your 
patch resolves the problems. However, I think the UI feels a little 
funny in the case of the file being deleted by another process. If the 
file is modified then we prompt the user informing them and asking if 
they'd like to first reload/re-edit, or overwrite, or just cancel. If 
the file has disappeared from disk, then it just saves as usual, and the 
standard "Changes Saved" dialog appears. This is /okay/, and there's no 
point in showing the "Reload file?" dialog if the file is gone, but 
perhaps there should be a warning dialog that informs the user that 
their file has mysteriously disappeared from the disk, even though it 
used to be there? Anyway this is just a hint at a possible feature 
enhancement, if you disagree with this UI change let me know and this 
patch can go in as-is.

Thanks,

-- 
Andrew A