/hg/icedtea-web: Fixed cache tests: CacheReproducerTest changed ...

[Jiri Vanek]

Hi!

This may be worthy to backport to 1.5 May some intern elaborate?

Also there may be more stupid failures like this. Again may some of our newbies elaborate?

[send from phone]


J.

On 05/23/2014 03:03 PM, jvanek at icedtea.classpath.org wrote:
> changeset e5a7d39eecbb in /hg/icedtea-web
> details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=e5a7d39eecbb
> author: Jiri Vanek <jvanek at redhat.com>
> date: Fri May 23 15:02:48 2014 +0200
>
> 	Fixed cache tests: CacheReproducerTest changed condition on checking cache dir from not existing to being empty,
>
>
> diffstat:
>
>   ChangeLog                                                                   |  6 ++++++
>   tests/reproducers/signed/CacheReproducer/testcases/CacheReproducerTest.java |  2 +-
>   2 files changed, 7 insertions(+), 1 deletions(-)
>
> diffs (25 lines):
>
> diff -r c97ba9284e7e -r e5a7d39eecbb ChangeLog
> --- a/ChangeLog	Fri May 23 14:13:26 2014 +0200
> +++ b/ChangeLog	Fri May 23 15:02:48 2014 +0200
> @@ -1,3 +1,9 @@
> +2014-05-23  Jiri Vanek  <jvanek at redhat.com>
> +
> +	Fixed cache tests
> +	* tests/reproducers/signed/CacheReproducer/testcases/CacheReproducerTest.java:
> +	changed condition on checking cache dir from not existing to being empty,
> +
>   2014-05-23  Jiri Vanek  <jvanek at redhat.com>
>
>   	Minor code enhancements: Enum for HEAD and GET, urlutils classes moved to UrlUtils
> diff -r c97ba9284e7e -r e5a7d39eecbb tests/reproducers/signed/CacheReproducer/testcases/CacheReproducerTest.java
> --- a/tests/reproducers/signed/CacheReproducer/testcases/CacheReproducerTest.java	Fri May 23 14:13:26 2014 +0200
> +++ b/tests/reproducers/signed/CacheReproducer/testcases/CacheReproducerTest.java	Fri May 23 15:02:48 2014 +0200
> @@ -346,7 +346,7 @@
>
>           }
>           tryToClearcache();
> -        Assert.assertFalse("icedtea cache " + icedteaCache.getAbsolutePath() + " should not exist after clearing", icedteaCache.exists());
> +        Assert.assertTrue("icedtea cache " + icedteaCache.getAbsolutePath() + " should be empty after clearing", icedteaCache.listFiles().length == 0);
>       }
>
>       private static String loadFile(File f) throws FileNotFoundException, UnsupportedEncodingException, IOException {
>