[rfc][icedtea-web] Fix to PluginMessage dates for PR2063
Jie Kang
jkang at redhat.com
Tue Nov 4 14:27:03 UTC 2014
----- Original Message -----
> On 11/03/2014 10:17 PM, Jie Kang wrote:
>
> I really did no mess? I really would expect console to show invlaid dates
> header now... (aka = ar eyou sure??)
Hmm. You are right, the headers don't get localized. I have attached two new patches with two different versions of fixes. I am not sure which is better:
The most important difference is:
Version 1: p.date = main[4];
versus
Version 2: p.date = FileLog.getPluginSharedFormatter().format(p.originalTimeStamp);
I tried it with LANG=en_CA, en_US, cs_CZ, de_CZ, pl_PL and the console seems to show valid dates. Below are the dates shown:
Version 1:
en_CA:
Tue Nov 04 08:44:59 EST 2014
en_US:
Tue Nov 04 08:45:35 EST 2014
de_DE
Di Nov 04 09:01:04 EST 2014
cs_CZ
Út lis 04 09:02:52 EST 2014
pl_PL
wto lis 04 09:21:56 EST 2014
Version 2:
en_CA:
Tue Nov 04 08:44:59 EST 2014
en_US:
Tue Nov 04 08:45:35 EST 2014
de_DE
Di Nov 04 09:01:04 EST 2014
cs_CZ
Út XI 04 09:02:52 EST 2014
pl_PL
wto lis 04 09:21:04 EST 2014
Between the two versions, the only difference (so far) is the output in cs_CZ locale.
Which do you prefer?
>
> Also I would keep the comments ffom my original pastebin here.
Sure, I will add them. I meant to but I forgot, sorry;;
Regards,
>
> If you disagree with the comments, then maybe remove the duplicated date at
> all?
>
> Ty!
> J.
> > Hello,
> >
> >
> > The attached patch is a small fix to PluginMessage addressing PR2063.
> >
> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2063
> >
> >
> > Thoughts?
> >
> >
> > Regards,
> >
>
>
--
Jie Kang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-pr2063-version-2.patch
Type: text/x-patch
Size: 2686 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20141104/74724d32/itw-pr2063-version-2-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-pr2063-version-1.patch
Type: text/x-patch
Size: 2690 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20141104/74724d32/itw-pr2063-version-1-0001.patch>
More information about the distro-pkg-dev
mailing list