[rfc][icedtea-web] Fix to PluginMessage dates for PR2063

[Jiri Vanek]

On 11/04/2014 03:27 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> On 11/03/2014 10:17 PM, Jie Kang wrote:
>>
>> I really did no mess? I really would expect console to show invlaid dates
>> header now... (aka = ar eyou sure??)
>
> Hmm. You are right, the headers don't get localized. I have attached two new patches with two different versions of fixes. I am not sure which is better:
>
> The most important difference is:
>
> Version 1: p.date = main[4];

Yes , I vote for v1 deffinitely.

However - the sorting in consoel could not work for you - have youtried!?!?!?

Tehre is:
                 case 4:
                     Collections.sort(sortedData, new CatchedMessageWithHeaderComparator() {
                         @Override
                         public int body(MessageWithHeader o1, MessageWithHeader o2) {
                             return o1.getHeader().date.compareTo(o2.getHeader().date);
                         }
                     });

You  had to got compley insane results....



I think the fix must go deeper.

What I consider as best fix is:
in console ouput (in header is on) to have the  most correct "result of  main[4]" //rfc
However, the sorting operation must be done against originalTimeStamp . hmm. I would like to test, 
if there canbe case when the originalTimeStamp and p.date may have really different (eg by hours or 
more)  values....

J.

>
> versus
>
> Version 2: p.date = FileLog.getPluginSharedFormatter().format(p.originalTimeStamp);
>
>
> I tried it with LANG=en_CA, en_US, cs_CZ, de_CZ, pl_PL and the console seems to show valid dates. Below are the dates shown:
>
> Version 1:
>
> en_CA:
>    Tue Nov 04 08:44:59 EST 2014
> en_US:
>    Tue Nov 04 08:45:35 EST 2014
> de_DE
>    Di Nov 04 09:01:04 EST 2014
> cs_CZ
>    Út lis 04 09:02:52 EST 2014
> pl_PL
>    wto lis 04 09:21:56 EST 2014
>
>
> Version 2:
>
> en_CA:
>    Tue Nov 04 08:44:59 EST 2014
> en_US:
>    Tue Nov 04 08:45:35 EST 2014
> de_DE
>    Di Nov 04 09:01:04 EST 2014
> cs_CZ
>    Út XI 04 09:02:52 EST 2014
> pl_PL
>    wto lis 04 09:21:04 EST 2014
>
>
> Between the two versions, the only difference (so far) is the output in cs_CZ locale.
>
>
> Which do you prefer?
>
>>
>> Also I would keep the comments ffom my original pastebin here.
>
>
> Sure, I will add them. I meant to but I forgot, sorry;;
>
>
> Regards,
>
>>
>> If you disagree with the comments, then maybe remove the duplicated date at
>> all?
>>
>> Ty!
>>     J.
>>> Hello,
>>>
>>>
>>> The attached patch is a small fix to PluginMessage addressing PR2063.
>>>
>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2063
>>>
>>>
>>> Thoughts?
>>>
>>>
>>> Regards,
>>>
>>
>>
>