[rfc][icedtea-web] Fix to PluginMessage dates for PR2063

[Jie Kang]

----- Original Message -----
> On 11/04/2014 03:27 PM, Jie Kang wrote:
> >
> >
> > ----- Original Message -----
> >> On 11/03/2014 10:17 PM, Jie Kang wrote:
> >>
> >> I really did no mess? I really would expect console to show invlaid dates
> >> header now... (aka = ar eyou sure??)
> >
> > Hmm. You are right, the headers don't get localized. I have attached two
> > new patches with two different versions of fixes. I am not sure which is
> > better:
> >
> > The most important difference is:
> >
> > Version 1: p.date = main[4];
> 
> Yes , I vote for v1 deffinitely.
> 
> However - the sorting in consoel could not work for you - have youtried!?!?!?
> 
> Tehre is:
>                  case 4:
>                      Collections.sort(sortedData, new
>                      CatchedMessageWithHeaderComparator() {
>                          @Override
>                          public int body(MessageWithHeader o1,
>                          MessageWithHeader o2) {
>                              return
>                              o1.getHeader().date.compareTo(o2.getHeader().date);
>                          }
>                      });
> 
> You  had to got compley insane results....
> 
> 
> 
> I think the fix must go deeper.
> 
> What I consider as best fix is:
> in console ouput (in header is on) to have the  most correct "result of
> main[4]" //rfc
> However, the sorting operation must be done against originalTimeStamp . hmm.
> I would like to test,
> if there canbe case when the originalTimeStamp and p.date may have really
> different (eg by hours or
> more)  values....

Hello,


Hmm. Well I did a patch that covers the sorting (attached), but I noticed that itw-applet messages don't get localized:

[jkang][ITW-APPLET][MESSAGE_DEBUG][Fri Nov 14 17:49:28 CET 2014]
[jkang][ITW-C-PLUGIN][MESSAGE_DEBUG][Fr Nov 14 17:49:08 CET 2014]


Should we also localize the java dates too? I think then version 2 will be better, since the java date localization != strftime localization:

e.g: 
cs_CZ
    Út lis 04 09:02:52 EST 2014 : strftime format
    Út XI 04 09:02:52 EST 2014 : java date format

I think it will be much harder to convert java date -> strftime date, as opposed to strftime date/timestamp -> java date.


Ugh.. Or can we leave as is...



Regards,



> 
> J.
> 
> >
> > versus
> >
> > Version 2: p.date =
> > FileLog.getPluginSharedFormatter().format(p.originalTimeStamp);
> >
> >
> > I tried it with LANG=en_CA, en_US, cs_CZ, de_CZ, pl_PL and the console
> > seems to show valid dates. Below are the dates shown:
> >
> > Version 1:
> >
> > en_CA:
> >    Tue Nov 04 08:44:59 EST 2014
> > en_US:
> >    Tue Nov 04 08:45:35 EST 2014
> > de_DE
> >    Di Nov 04 09:01:04 EST 2014
> > cs_CZ
> >    Út lis 04 09:02:52 EST 2014
> > pl_PL
> >    wto lis 04 09:21:56 EST 2014
> >
> >
> > Version 2:
> >
> > en_CA:
> >    Tue Nov 04 08:44:59 EST 2014
> > en_US:
> >    Tue Nov 04 08:45:35 EST 2014
> > de_DE
> >    Di Nov 04 09:01:04 EST 2014
> > cs_CZ
> >    Út XI 04 09:02:52 EST 2014
> > pl_PL
> >    wto lis 04 09:21:04 EST 2014
> >
> >
> > Between the two versions, the only difference (so far) is the output in
> > cs_CZ locale.
> >
> >
> > Which do you prefer?
> >
> >>
> >> Also I would keep the comments ffom my original pastebin here.
> >
> >
> > Sure, I will add them. I meant to but I forgot, sorry;;
> >
> >
> > Regards,
> >
> >>
> >> If you disagree with the comments, then maybe remove the duplicated date
> >> at
> >> all?
> >>
> >> Ty!
> >>     J.
> >>> Hello,
> >>>
> >>>
> >>> The attached patch is a small fix to PluginMessage addressing PR2063.
> >>>
> >>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2063
> >>>
> >>>
> >>> Thoughts?
> >>>
> >>>
> >>> Regards,
> >>>
> >>
> >>
> >
> 
> 

-- 

Jie Kang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-pr2063-2.patch
Type: text/x-patch
Size: 4841 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20141114/933e63c4/itw-pr2063-2-0001.patch>