/hg/icedtea-web: IcedTea-Web Splashscreen allows zero or one hyp...

Jiri Vanek jvanek at redhat.com
Mon Oct 6 08:30:33 UTC 2014


Shouldnt it be zero to infinity hyphens?
> +++ b/launcher/launchers.in	Fri Oct 03 14:20:40 2014 -0400
> @@ -53,7 +53,7 @@
>       *)
>         ARGS[$j]="$1"
>         j=$((j+1))
> -      if [ "$1" = "-headless" ] ; then
> +      if [[ "$1" =~ ^[-]{0,1}headless ]] ; then

  =>  +      if [[ "$1" =~ ^[-]*headless ]] ; then

I rember it like this....

?
>           SPLASH="false"
>         fi
>         ;;
>


diff -r 6d62f68fb037 launcher/launchers.in
--- a/launcher/launchers.in	Mon Sep 22 17:10:07 2014 +0200
+++ b/launcher/launchers.in	Thu Sep 25 17:26:49 2014 -0400
@@ -53,7 +53,7 @@
      *)
        ARGS[$j]="$1"
        j=$((j+1))
-      if [ "$1" = "-headless" ] ; then
+      if [[ "$1" =~ -*headless ]] ; then
          SPLASH="false"
        fi
        ;;


is your original chnageset. I have not found discussion about this chnage, and unless I overlooked it, it is violating the review process.


????
J.


More information about the distro-pkg-dev mailing list