/hg/icedtea-web: IcedTea-Web Splashscreen allows zero or one hyp...

[Lukasz Dracz]

Hello,

Sorry, I thought at the time the change/difference was small enough but I agree even the smallest changes should get reviewed. The reasoning behind the change is that I thought -*headless  was not a correct change, since really only headless and -headless are accepted as options, anything with more dashes is not accepted such as --headless, ---headless, -----headless etc. It did not make sense to have a user put ---headless, then have the icedtea-web splash screen not appear only to get a message back that ---headless is not an accepted option. That is why I changed what was agreed upon to what is actually supported, which is only headless or -headless.

Once again I am sorry, I did not mean to violate the review process. Do you want to support -*headless ? So anything from headless to --*--headless I can make the required changes if that is what is wanted in option parser. Should the change be reverted ?

Sincerely, 
Lukasz Dracz

----- Original Message -----
> From: "Jiri Vanek" <jvanek at redhat.com>
> To: ldracz at icedtea.classpath.org, distro-pkg-dev at openjdk.java.net
> Sent: Monday, October 6, 2014 4:30:33 AM
> Subject: Re: /hg/icedtea-web: IcedTea-Web Splashscreen allows zero or one	hyp...
> 
> Shouldnt it be zero to infinity hyphens?
> > +++ b/launcher/launchers.in	Fri Oct 03 14:20:40 2014 -0400
> > @@ -53,7 +53,7 @@
> >       *)
> >         ARGS[$j]="$1"
> >         j=$((j+1))
> > -      if [ "$1" = "-headless" ] ; then
> > +      if [[ "$1" =~ ^[-]{0,1}headless ]] ; then
> 
>   =>  +      if [[ "$1" =~ ^[-]*headless ]] ; then
> 
> I rember it like this....
> 
> ?
> >           SPLASH="false"
> >         fi
> >         ;;
> >
> 
> 
> diff -r 6d62f68fb037 launcher/launchers.in
> --- a/launcher/launchers.in	Mon Sep 22 17:10:07 2014 +0200
> +++ b/launcher/launchers.in	Thu Sep 25 17:26:49 2014 -0400
> @@ -53,7 +53,7 @@
>       *)
>         ARGS[$j]="$1"
>         j=$((j+1))
> -      if [ "$1" = "-headless" ] ; then
> +      if [[ "$1" =~ -*headless ]] ; then
>           SPLASH="false"
>         fi
>         ;;
> 
> 
> is your original chnageset. I have not found discussion about this chnage,
> and unless I overlooked it, it is violating the review process.
> 
> 
> ????
> J.
>