[rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space

[Jie Kang]

----- Original Message -----
> Hello,
> 
> Okay so this patch, uses disabling/enabling instead of hiding/showing. Also
> put the "Java stores application ..." description to always be at the top
> where as the rest of the components will be centered.
> Also changed from powers of two to increments of 10 but not jumps of
> 1,10,100,1000,10000 etc. but instead to
> 0,1,2,3,...,7,8,9,10,20,30...80,90,100,200,300...800,900,1000,2000,3000 etc.
> I think this way is best as it does not jump to the larger values too
> quickly.
> 
> As for my opinion, I think disabling is better than hiding, as it still shows
> the user the possibilities in the panel even though they are not active. I
> also liked the powers of two spinner much more personally but from a user's
> point of view I agree that increments of 10 are more intuitive and easier to
> understand.
> 
> Thank you,
> Lukasz Dracz

Hello,

When you check the 'limit cache size box' with a size of 0, the JAR compression option and cache location option are disabled. At the moment, limiting cache size to 0 means that once icedtea-web finishes, the cache is cleared of all files. 

I think the description for Caching should be reworded a little to make this known. E.g.

"No files will be cached. Cached files will be deleted." can be reworded to something like:
"Cached files will be deleted on icedtea-web close.

As well, the ability to choose where icedtea-web downloads file should still be enabled even if cache has a limit of 0.


In terms of code, it functionally looks okay but I would strongly suggest adding logically placed line spaces throughout the code for easier reading.

E.g. I think the code below could be spaced out.

+        //Override getNextValue and getPreviousValue to make it jump to the closest increment/decrement of step size
+        final Long configCacheSize = parseLong(this.config.getProperty(Properties.CACHE_MAX_SIZE.toString()));
+        final Long initialCacheSize = configCacheSize < CACHE_MIN_SIZE ? CACHE_MIN_SIZE : configCacheSize;
+        final SpinnerNumberModel snmCacheSize = new PowerOfSpinnerNumberModel(initialCacheSize, TemporaryInternetFilesPanel.CACHE_MIN_SIZE, TemporaryInternetFilesPanel.CACHE_MAX_SIZE, TemporaryInternetFilesPanel.SPINNER_STEP_SIZE);
+        cacheSizeSpinner.setModel(snmCacheSize);
+        final SpinnerChangeListener listener = new SpinnerChangeListener();
+        cacheSizeSpinner.addChangeListener(listener);
+        cacheSizeSpinner.setToolTipText(Translator.R("TIFPCacheSizeSpinnerTooltip", CACHE_MIN_SIZE, CACHE_MAX_SIZE));
+        limitCacheSizeCheckBox.setSelected(configCacheSize >= CACHE_MIN_SIZE);
+        limitCacheSizeCheckBox.addItemListener(new CheckboxItemListener());


Regards,


-- 

Jie Kang