[rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space

Lukasz Dracz ldracz at redhat.com
Mon Sep 8 18:38:35 UTC 2014


Hello,

> Hello,
> 
> When you check the 'limit cache size box' with a size of 0, the JAR
> compression option and cache location option are disabled. At the moment,
> limiting cache size to 0 means that once icedtea-web finishes, the cache is
> cleared of all files.
> 
> I think the description for Caching should be reworded a little to make this
> known. E.g.
> 
> "No files will be cached. Cached files will be deleted." can be reworded to
> something like:
> "Cached files will be deleted on icedtea-web close.

Okay

> As well, the ability to choose where icedtea-web downloads file should still
> be enabled even if cache has a limit of 0.

Yes since it still downloads the files even if they are deleted after use. 
This provides the user with more choice on where they want the files to be temporarily.

> In terms of code, it functionally looks okay but I would strongly suggest
> adding logically placed line spaces throughout the code for easier reading.

Yes, sorry about that, I added spaces in a bunch of places now to increase readability.

Thank you,
Lukasz Dracz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cacheSizeSpinner-21.patch
Type: text/x-patch
Size: 22989 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140908/7414f8db/cacheSizeSpinner-21-0001.patch>


More information about the distro-pkg-dev mailing list