[fyi] [icedtea-web]failing unittest testSetFileNull
Lukasz Dracz
ldracz at redhat.com
Wed Sep 10 18:11:15 UTC 2014
Hello,
> > > Hello,
> > >
> > > > FAILED:
> > > > testSetFileNull(net.sourceforge.jnlp.security.policyeditor.PolicyFileModelTest)
> > > > Expected
> > > > exception: java.lang.NullPointerException
> > > >
> > > >
> > > > Is now appearing. I think thatthis was actually fixed in sources, but
> > > > obviously the test was not
> > > > adapted. Can responsible person fix?
> > >
> > > I added a check for if it is null then throw a Null Pointer Exception.
> > >
> > > Okay to push ?
> >
> > No. The null value was made acceptable and the test was not updated in
> > response to the change.
> >
> > Please check code usages, etc. before changing functionality.
> >
> > The test can probably be removed.
Alright, Sorry here is updated patch with removed test.
Thanks,
Lukasz Dracz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testSetFileNullRemoved.patch
Type: text/x-patch
Size: 753 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140910/e4a3d23e/testSetFileNullRemoved.patch>
More information about the distro-pkg-dev
mailing list