[fyi] [icedtea-web]failing unittest testSetFileNull

Jiri Vanek jvanek at redhat.com
Thu Sep 11 09:19:19 UTC 2014


On 09/10/2014 08:11 PM, Lukasz Dracz wrote:
> Hello,
>
>>>> Hello,
>>>>
>>>>> FAILED:
>>>>> testSetFileNull(net.sourceforge.jnlp.security.policyeditor.PolicyFileModelTest)
>>>>> Expected
>>>>> exception: java.lang.NullPointerException
>>>>>
>>>>>
>>>>> Is now appearing. I think thatthis was actually fixed in sources, but
>>>>> obviously the test was not
>>>>> adapted. Can responsible person fix?
>>>>
>>>> I added a check for if it is null then throw a Null Pointer Exception.
>>>>
>>>> Okay to push ?
>>>
>>> No. The null value was made acceptable and the test was not updated in
>>> response to the change.
>>>
>>> Please check code usages, etc. before changing functionality.
>>>
>>> The test can probably be removed.
>
> Alright, Sorry here is updated patch with removed test.
>
> Thanks,
> Lukasz Dracz
>
No removal.


Ensure that it works correctly even with null parameter.


There is no similar test.

J.


More information about the distro-pkg-dev mailing list