[rfc][icedtea-web][itweb-settings] Improve IcedTea-Web cache disk space

Thu Sep 11 20:25:55 UTC 2014

Hello,

> As this patch seems kind of the last version that actually got pushed, I am
> replying to this posting. Are my few nits.
> 
> Regarding the discussion about cache size 0 and IcedTea-Web's behavior in
> this
> case, I suppose that displaying the TIFPCacheSizeSetToNoCaching message is an
> acceptable compromise (because it describes what will actually happen), but
> only
> as long as we can expect a followup patch that makes IcedTea-Web use a
> "memory
> only" cache.

Yeah, I will try to get a "memory only" cache working sometime in the future.

>  > diff -r af89bcaa02a2 -r e30d71ab91c6 netx/net/sourceforge/jnlp/resources
>  > /Messages.properties
>  > --- a/netx/net/sourceforge/jnlp/resources/Messages.properties	Wed Sep 10
>  > 09:45:10 2014 -0400
>  > +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties	Wed Sep 10
>  > 10:22:46 2014 -0400
>  > @@ -801,6 +801,10 @@
>  >  TIFPDeleteFiles=Delete files
>  >  TIFPViewFiles=View files...
>  >  TIFPFileChooserChooseButton=Choose
>  > +TIFPLimitCacheSize=Limit cache size
>  > +TIFPCacheSizeSpinnerValueTooLargeWarning=<html><b>WARNING:</b> Uses more
>  > space than {0} MB available</html>
>  > +TIFPCacheSizeSpinnerLargeValueWarning=<html> Available: {0} MB</html>
> 
> Drop the html tags. They are not required here. Besides, HTML trims all
> leading
> and trailing white spaces, as well as replaces multiple white spaces between
> words with one SPACE (\u0020) character. This probably leads to undesired
> behavior here, if not now then maybe in the future.

Okay.

>  > +TIFPCacheSizeSetToNoCaching=<html>Cached files will be deleted on
>  > icedtea-web close.</html>
> 
> Again, drop the html tags. They do not serve any purpose here.
> Also, please use the proper branding, which is "IcedTea-Web". We may have
> even a
> public static final constant for this.
> And finally, this sentence needs rewording to be proper English. I would
> suggest:
> 
> Cached files will be deleted when IcedTea-Web terminates.
>
> I think the term "terminates" is appropriate here, because the user actually
> never gets to "close" IcedTea-Web directly since its shutdown or
> /termination/
> is controlled indirectly via the JNLP application or the JVM.

Yeah, this is much better.

> One last thing I have experienced is that a message for
> "TIFPCacheSizeSpinnerTooltip" is missing when hovering over the cache size
> spinner. Please fix this!

Yeah, the tooltip was removed previously due to a weird bug appearing with the tooltip not disappearing when resized to with the tooltip reaching outside the window. I have checked and can't seem to reproduce this bug, I think it go fixed when I refactored the layout from a panel within a panel to just everything in one panel.

Also I made it so the tooltip is disabled when the spinner is disabled which I assumed is the desired behaviour.

> Thank you for improving the cache size UI controls. ;-)

No problem, thanks for all the suggestions and reviews :)

> Jacob

Thank you,
Lukasz Dracz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: improveCacheDiskSpacePanel.patch
Type: text/x-patch
Size: 2626 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140911/7cd589e9/improveCacheDiskSpacePanel.patch>