[rfc][icedtea-web][itweb-settings] Improve IcedTea-Web cache disk space

Sat Sep 13 22:00:02 UTC 2014

On 09/11/2014 at 10:25 PM, Lukasz Dracz wrote:
>>> diff -r af89bcaa02a2 -r e30d71ab91c6 netx/net/sourceforge/jnlp/resources
>>> /Messages.properties
>>> --- a/netx/net/sourceforge/jnlp/resources/Messages.properties	Wed Sep 10
>>> 09:45:10 2014 -0400
>>> +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties	Wed Sep 10
>>> 10:22:46 2014 -0400
>>> @@ -801,6 +801,10 @@
>>>  TIFPDeleteFiles=Delete files
>>>  TIFPViewFiles=View files...
>>>  TIFPFileChooserChooseButton=Choose
>>> +TIFPLimitCacheSize=Limit cache size
>>> +TIFPCacheSizeSpinnerValueTooLargeWarning=<html><b>WARNING:</b> Uses more
>>> space than {0} MB available</html>

Keep html tags here because they serve a reasonable purpose.

>>> +TIFPCacheSizeSpinnerLargeValueWarning=<html> Available: {0} MB</html>
>>
>> Drop the html tags. They are not required here. Besides, HTML trims all
>> leading
>> and trailing white spaces, as well as replaces multiple white spaces between
>> words with one SPACE (\u0020) character. This probably leads to undesired
>> behavior here, if not now then maybe in the future.
>
> Okay.

I am sorry, but we have run into a misunderstanding here. :-\ My comment was not 
meant to remove /all/ html tags. What I meant was that the html tags should be 
only removed from those messages which do not actually require HTML features. 
So, to be specific this time: TIFPCacheSizeSpinnerLargeValueWarning, 
TIFPCacheSizeSetToNoCaching, and TIFPCacheSizeSpinnerTooltip only.


diff -r e30d71ab91c6 
netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java

--- a/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java 
Wed Sep 10 10:22:46 2014 -0400
+++ b/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java 
Thu Sep 11 16:15:11 2014 -0400
[...]
@@ -402,10 +401,11 @@
          cacheSizeWarningLabel.setEnabled(bool);

          if(bool == false) {
+            cacheSizeSpinner.setToolTipText(null);
 
cacheSizeWarningLabel.setText(Translator.R("TIFPCacheSizeSpinnerLargeValueWarning", 
usableDiskSpace));
          } else {

-            final long cacheSizeSpinnerValue = (long) cacheSizeSpinner.getValue();
+ 
cacheSizeSpinner.setToolTipText(Translator.R("TIFPCacheSizeSpinnerTooltip", 
CACHE_MIN_SIZE, CACHE_MAX_SIZE));            final long cacheSizeSpinnerValue = 
(long) cacheSizeSpinner.getValue();

Please check formatting here. I assume that the declaration and initialization 
statement of "cacheSizeSpinnerValue" was intended to be on a line of its own, 
after the "cacheSizeSpinner.setToolTipText()" statement.

After fixing this stuff, I think it is okay to push. :-)

Jacob
