[rfc][icedtea-web][itweb-settings] Improve IcedTea-Web cache disk space

[Lukasz Dracz]

Hello,


> I am sorry, but we have run into a misunderstanding here. :-\ My comment was
> not
> meant to remove /all/ html tags. What I meant was that the html tags should
> be
> only removed from those messages which do not actually require HTML features.
> So, to be specific this time: TIFPCacheSizeSpinnerLargeValueWarning,
> TIFPCacheSizeSetToNoCaching, and TIFPCacheSizeSpinnerTooltip only.

Ah okay, sorry for misunderstanding.

> diff -r e30d71ab91c6
> netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
> --- a/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
> Wed Sep 10 10:22:46 2014 -0400
> +++ b/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
> Thu Sep 11 16:15:11 2014 -0400
> [...]
> @@ -402,10 +401,11 @@
>           cacheSizeWarningLabel.setEnabled(bool);
> 
>           if(bool == false) {
> +            cacheSizeSpinner.setToolTipText(null);
>  
> cacheSizeWarningLabel.setText(Translator.R("TIFPCacheSizeSpinnerLargeValueWarning",
> usableDiskSpace));
>           } else {
> 
> -            final long cacheSizeSpinnerValue = (long)
> cacheSizeSpinner.getValue();
> +
> cacheSizeSpinner.setToolTipText(Translator.R("TIFPCacheSizeSpinnerTooltip",
> CACHE_MIN_SIZE, CACHE_MAX_SIZE));            final long cacheSizeSpinnerValue
> =
> (long) cacheSizeSpinner.getValue();
> 
> Please check formatting here. I assume that the declaration and
> initialization
> statement of "cacheSizeSpinnerValue" was intended to be on a line of its own,
> after the "cacheSizeSpinner.setToolTipText()" statement.

Good catch !

> After fixing this stuff, I think it is okay to push. :-)
> 
> Jacob
> 

I pushed with the changes you suggested. Thanks for the review and the catch :) !

Regards,
Lukasz Dracz