[rfc][icedtea-web] Makefile New Whitelisted-Dist-Test option
Jie Kang
jkang at redhat.com
Mon Sep 22 21:17:47 UTC 2014
Hello,
This patch expands on the Makefile Reproducer Test patch [1].
[1] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2014-September/029581.html
There is now a new make rule: 'run-netx-whitelisted-dist-tests'
This rule runs the reproducers similar to 'run-netx-dist-tests', except it only processes (compiles, etc.) the resources filtered by the whitelist.
As well, the rule 'run-netx-dist-tests' has now reverted back to processing all resources (ie. what it used to do before the Makefile Reproducer Test patch [1])
Thoughts?
Just a note, the purpose of the "stamps/whitelist-filter.stamp" rule having:
echo ".*" ...
is to maintain compatibility. Though the "all-whitelist" rule also contains duplicate code, there can be situations where neither "all-whitelist" or "filtered-whitelist" are not called. E.g. if user runs "make stamps/netx-dist-tests-prepare-reproducers.stamp". This is the solution I came up with to allow for all possible make commands to continue to work and for the user to be able to quickly switch between running "make run-netx-dist-tests" and "make run-netx-whitelisted-dist-tests" without always having to perform "make clean-netx-dist-tests". I guess a TLDR is that it's to prevent regressions.
If this patch is accepted I will update the wiki and documentation for this feature.
Regards,
--
Jie Kang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-makefile-whitelisted-2.patch
Type: text/x-patch
Size: 3718 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140922/29e8e508/itw-makefile-whitelisted-2.patch>
More information about the distro-pkg-dev
mailing list