[rfc][icedtea-web] Makefile New Whitelisted-Dist-Test option

Jiri Vanek jvanek at redhat.com
Tue Sep 23 12:08:35 UTC 2014


On 09/22/2014 11:17 PM, Jie Kang wrote:
> Hello,
>
> This patch expands on the Makefile Reproducer Test patch [1].
>
> [1] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2014-September/029581.html
>
>
> There is now a new make rule: 'run-netx-whitelisted-dist-tests'
>
> This rule runs the reproducers similar to 'run-netx-dist-tests', except it only processes (compiles, etc.) the resources filtered by the whitelist.
>
> As well, the rule 'run-netx-dist-tests' has now reverted back to processing all resources (ie. what it used to do before the Makefile Reproducer Test patch [1])
>
> Thoughts?
>
> Just a note, the purpose of the "stamps/whitelist-filter.stamp" rule having:
>    echo ".*" ...
> is to maintain compatibility. Though the "all-whitelist" rule also contains duplicate code, there can be situations where neither "all-whitelist" or "filtered-whitelist" are not called. E.g. if user runs "make stamps/netx-dist-tests-prepare-reproducers.stamp". This is the solution I came up with to allow for all possible make commands to continue to work and for the user to be able to quickly switch between running "make run-netx-dist-tests" and "make run-netx-whitelisted-dist-tests" without always having to perform "make clean-netx-dist-tests". I guess a TLDR is that it's to prevent regressions.
>
> If this patch is accepted I will update the wiki and documentation for this feature.
>
>
> Regards,
>

Hm. only hint to approach. Why  not configure switch? This seems to me overcomplexed.  What is 
advantage of this?
Once the new and old targets will be run in unpredicted order, the result can be unpredictible.
Also I can not see the reverted part in patch.

J.


More information about the distro-pkg-dev mailing list