[Bug 2209] New: Duplication of PROC_CHECK_INTERVAL

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2209

            Bug ID: 2209
           Summary: Duplication of PROC_CHECK_INTERVAL
           Product: Thermostat
           Version: hg
          Hardware: x86_64
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Thermostat
          Assignee: unassigned at icedtea.classpath.org
          Reporter: omajid at redhat.com
                CC: thermostat at icedtea.classpath.org

Lots of backends poll /proc/ repeatedly. Each of them uses copy-pasted interval
value:

$ ack PROC_CHECK
host-cpu/agent/src/main/java/com/redhat/thermostat/host/cpu/agent/internal/HostCpuBackend.java
53:    private static final long PROC_CHECK_INTERVAL = 1000; // TODO make this
configurable.
86:            }, 0, PROC_CHECK_INTERVAL, TimeUnit.MILLISECONDS);

host-memory/agent/src/main/java/com/redhat/thermostat/host/memory/agent/internal/HostMemoryBackend.java
50:    private static final long PROC_CHECK_INTERVAL = 1000; // TODO make this
configurable.
77:            }, 0, PROC_CHECK_INTERVAL, TimeUnit.MILLISECONDS);

vm-cpu/agent/src/main/java/com/redhat/thermostat/vm/cpu/agent/internal/VmCpuBackend.java
65:    static final long PROC_CHECK_INTERVAL = 1000; // TODO make this
configurable.
115:            }, 0, PROC_CHECK_INTERVAL, TimeUnit.MILLISECONDS);

We should make this PROC_CHECK_INTERVAL a single value that is read by multiple
backends (and threads) so they all use the same interval. And, as the TODO
says, it should be adjustable at runtime.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150203/6ed10105/attachment-0001.html>