[rfc][icedtea-web] rconsider offline and xoffline

Jiri Vanek jvanek at redhat.com
Fri Feb 13 08:46:16 UTC 2015


On 02/10/2015 04:14 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> Currently the offline environment of ITW is not perfect
>>
>> Applets in browser works even when network is off -its good.
>>
>> Also all jnlp apps works offline, unless allow-offline is missing. Same is
>> for -html switch, becasue
>> pluginbridge by defualt do not specified it. If -Xoffline is specified, then
>> this check is not done,
>> and all -html applets an javaws apps without offline-allowed  works.
>>
>>
>> I would like to remove all possible checks of it.
>>
>> Most direct approach is attached. But maybe better one to remove all usages
>> of isOfflineAllowed may
>> be better (but then the comment is lost)
>>
>>
>> Thoughts?
>
> Hello,
>
> What happens to applets that only want to run 'Online'? You say 'Most applications are missusing it' but what about those applets that include/exclude the parameter correctly?

Thay will fail later with regular exception. So imho it is correct behavior.
>
> In your opinion, how does this change help? I feel like the original is still okay.

Nope. Currently you need to force Xoffline to achive it. (except regular appelts in browser)

However, year with xoffline proved me to be right. Apps were nearly always forbidden to run offline 
without any reason, and were working fine.
>
>
> If anything, I think removing the usages would be better. You can still keep the comment inside InformationDesc. Something like:

I dont think. It is quite wides spread, and before 1.6 goes out, maybe we reconsider. So I would 
rather use return true, and kept usage s for a while.
>
>       public boolean isOfflineAllowed() {
> +        //WARNING: Icedtea-Web ignores this parameter. Most applications do not use this correctly.
>           return null != getItem("offline-allowed");
>       }
>
>

TY!
  J.



More information about the distro-pkg-dev mailing list