[rfc][icedtea-web] rconsider offline and xoffline

[Jie Kang]

----- Original Message -----
> Currently the offline environment of ITW is not perfect
> 
> Applets in browser works even when network is off -its good.
> 
> Also all jnlp apps works offline, unless allow-offline is missing. Same is
> for -html switch, becasue
> pluginbridge by defualt do not specified it. If -Xoffline is specified, then
> this check is not done,
> and all -html applets an javaws apps without offline-allowed  works.
> 
> 
> I would like to remove all possible checks of it.
> 
> Most direct approach is attached. But maybe better one to remove all usages
> of isOfflineAllowed may
> be better (but then the comment is lost)
> 
> 
> Thoughts?

Hello,

What happens to applets that only want to run 'Online'? You say 'Most applications are missusing it' but what about those applets that include/exclude the parameter correctly? 

In your opinion, how does this change help? I feel like the original is still okay.


If anything, I think removing the usages would be better. You can still keep the comment inside InformationDesc. Something like:

     public boolean isOfflineAllowed() {
+        //WARNING: Icedtea-Web ignores this parameter. Most applications do not use this correctly.
         return null != getItem("offline-allowed");
     }


Regards,

> 
> Some following patch should be soemtunning of the cache. It is clearing
> itself somehow suspiciously
> often....
> 

-- 

Jie Kang

OpenJDK Team - Software Engineering Intern