[rfc][icedtea-web] Add quotes to Docs paths in Makefile

Wed Jan 21 09:36:30 UTC 2015

Well I'm author of this patch... Seeing Jie posted it, it may be probably  considered to be reviwed 
when Jie was writing this email.

Anyway  good to go from my side (and as jie posted it, probakly also from his side)

J.
On 12/23/2014 03:55 PM, Jie Kang wrote:
> Hello,
>
> As requested by jvanek: here is the patch for HEAD to add quotes to the Doc paths in Makefile.
>
> This is to prevent the error in building encountered below [1]
>
> Okay to push?
>
>
> Regards,
>
>
> [1]
>
> mkdir -p /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/icedtea-web-docs/1.6pre
> (fedora-0.1.pre01.fc21-x86_64) ; \
> HTML_DOCS_TARGET_DIR=/home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/icedtea-web-docs/1.6pre
> (fedora-0.1.pre01.fc21-x86_64)/html  ; \
> PLAIN_DOCS_TARGET_DIR=/home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/icedtea-web-docs/1.6pre
> (fedora-0.1.pre01.fc21-x86_64)/plain ; \
> MAN_DOCS_TARGET_DIR=/home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/icedtea-web-docs/1.6pre
> (fedora-0.1.pre01.fc21-x86_64)/man  ; \
> mkdir $HTML_DOCS_TARGET_DIR ; \
> mkdir $PLAIN_DOCS_TARGET_DIR ; \
> mkdir $MAN_DOCS_TARGET_DIR ; \
> HTML_DOCS_INDEX=$HTML_DOCS_TARGET_DIR/index.html ; \
> TP_COMMAND="/home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/bootstrap/jdk1.6.0/bin/java -cp
> /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/netx.build
> net.sourceforge.jnlp.util.docprovider.TextsProvider" ; \
> TP_TAIL="false 1.6pre (fedora-0.1.pre01.fc21-x86_64)" ; \
> LANG_BACKUP=$LANG ; \
> echo "<html><head><title>IcedTea-Web 1.6pre (fedora-0.1.pre01.fc21-x86_64)</title></head>" >
> $HTML_DOCS_INDEX ; \
> echo "<body><h3>IcedTea-Web 1.6pre (fedora-0.1.pre01.fc21-x86_64) docs:</h3>"  >> $HTML_DOCS_INDEX ; \
> for LANG_ID in en_US.UTF-8 cs_CZ.UTF-8 pl_PL.UTF-8 de_DE.UTF-8 ;  do \
>     ID=`echo "$LANG_ID" | head -c 2` ; \
>     ENCOD=`echo "$LANG_ID" | tail -c 6` ; \
>     export LANG=$LANG_ID; \
>     mkdir $HTML_DOCS_TARGET_DIR/$ID ; \
>     echo "<li><a href='$ID/icedtea-web.html'>$LANG_ID</a></li>"  >> $HTML_DOCS_INDEX ; \
>     $TP_COMMAND html $HTML_DOCS_TARGET_DIR/$ID false $TP_TAIL ; \
>     mkdir $PLAIN_DOCS_TARGET_DIR/$ID ; \
>     $TP_COMMAND plain $PLAIN_DOCS_TARGET_DIR/$ID 160 false $TP_TAIL; \
>     if [ $ID == "en" ] ; then \
>       MAN_DESC=$MAN_DOCS_TARGET_DIR/man1 ; \
>     else \
>       MAN_DESC=$MAN_DOCS_TARGET_DIR/$ID/man1 ; \
>     fi ; \
>     mkdir -p $MAN_DESC ; \
>     $TP_COMMAND man $ENCOD $MAN_DESC $TP_TAIL ; \
>     $TP_COMMAND htmlIntro
> /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/netx.build/net/sourceforge/jnlp/resources/about_$ID.html
> $TP_TAIL; \
> done ; \
> export LANG=$LANG_BACKUP ; \
> echo "</body></html>"  >> $HTML_DOCS_INDEX ; \
> touch stamps/generate-docs.stamp
> if test "xnetscape sun/applet" != x; then \
>     mkdir -p /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/liveconnect && \
>     /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/bootstrap/jdk1.6.0/bin/javac -g -encoding utf-8
>    -source 7 -target 7 \
>         -d /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/liveconnect \
>         -bootclasspath
> /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/netx.build:/home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/bootstrap/jdk1.6.0/jre/lib/rt.jar:/home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/bootstrap/jdk1.6.0/jre/lib/jsse.jar:/usr/share/java/js.jar:/home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/bootstrap/jdk1.6.0/jre/lib/resources.jar
> \
>         -classpath /usr/share/java/tagsoup.jar \
>         -sourcepath /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/plugin/icedteanp/java \
>         @liveconnect-source-files.txt ; \
> fi
> /bin/sh: -c: line 0: syntax error near unexpected token `('
> /bin/sh: -c: line 0: `mkdir -p
> /home/jvanek/rpmbuild/BUILD/icedtea-web-1.6pre/icedtea-web-docs/1.6pre
> (fedora-0.1.pre01.fc21-x86_64) ; \'
> Makefile:1079: recipe for target 'stamps/generate-docs.stamp' failed
> make: *** [stamps/generate-docs.stamp] Error 1
> make: *** Waiting for unfinished jobs....
>