[rfc][icedtea-web] Refactor initialize/download out of ResourceTracker and add tests

[Jiri Vanek]

On 12/30/2014 09:17 PM, Jie Kang wrote:
> Hello,
>
> The attached patch moves the download/initialize runnable into a separate class named ResourceDownloader. The tests applicable to the new ResourceDownloader have also been moved from ResourceTrackerTest to ResourceDownloaderTest.
>
> As well a number of tests have been added to ResourceDownloaderTest in order to ensure the capabilities of the downloader are maintained.
>

Yup. Looks good. Please follow Lukas' nits in separate changeset. Not as part of the refactoring.


Thank you both!


J.
>
> New tests of note:
>
> testDownloadResource
> testDownloadPackGzResource
> testDownloadVersionedResource
> testDownloadVersionedPackGzResource
> testDownloadLocalResourceFails
> testDownloadNotExistingResourceFails
>
> There are two cases that I will add in a separate patch:
>
> 1 : test redownloading using new setting in TinyHttpdImpl
> 2 : test download of gzip file (not packgz)
>
> These both need extra work in code outside of ResourceDownloader
>
>
> How does it look?
>
>
> Regards,
>