[rfc][icedtea-web] dont expect junit have hamcrest included
Jiri Vanek
jvanek at redhat.com
Thu Jan 29 09:59:12 UTC 2015
On 01/28/2015 08:57 PM, Omair Majid wrote:
> * Andrew Azores <aazores at redhat.com> [2015-01-28 12:31]:
>> Aha! This would be why I have never been able to get the ITW tests working
>> on my laptops - my JUnit doesn't include Hamcrest.
That explains failing unittets after yours patches! :))
Nope, just kidding :)
>>
>> +1 for fixing this
>
> Can you confirm that the patch fixes the unit tests and makes them run
> for you?
>
Still, if we drop the "transitive hamcrest" then the best solution should be applied:
If junit is found:
- check if junit contains hamcrest
- should be simple cllass compiling with importing some hamcrest class
- if does, no hamcrest search
- if does not, check for hamcrest
- if no hamcrest avaiable halt configure
Or use your curent approach
- always check for hamcrest, but continue if it do not exists.
- disadvantage is that missing hamcrest is quite hard to find from gotten exception
J.
More information about the distro-pkg-dev
mailing list