[rfc][icedtea-web] dont expect junit have hamcrest included

Omair Majid omajid at redhat.com
Fri Jan 30 21:12:29 UTC 2015


* Jiri Vanek <jvanek at redhat.com> [2015-01-29 04:59]:
> Still, if we drop the "transitive hamcrest" then the best solution should be applied:
> If junit is found:
>  - check if junit contains hamcrest
>    - should be simple cllass compiling with importing some hamcrest class
>    - if does, no hamcrest search
>    - if does not, check for hamcrest
>      - if no hamcrest avaiable halt configure

This does seem like the right approach.

> Or use your curent approach
>   - always check for hamcrest, but continue if it do not exists.
>   - disadvantage is that missing hamcrest is quite hard to find from gotten exception

How about I push my current patch, and then someone (possibly me) can
step in and further improve things to work as you suggested? We now know
this patch fixes tests on at least two systems.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the distro-pkg-dev mailing list