[rfc][icedtea-web] fixing typo in trusted-only reproducer

Andrew Azores aazores at redhat.com
Mon Jul 27 17:15:46 UTC 2015


On 27/07/15 11:53 AM, Jacob Wisor wrote:
> On 07/27/2015 at 05:08 PM Jiri Vanek wrote:
>>
>> -Trusted-only: true
>> +Trusted-Only: true
>>
>> in manifest.. so it was actually testing nothing :-/
>>
>> its here since begining
>> http://icedtea.classpath.org/hg/icedtea-web/annotate/dee18160ba9c/tests/reproducers/custom/TrustedOnlyAttribute/srcs/MANIFEST.MF 
>>
>>
>>
>> and more surprising is, that this typo do not affect tests results...
>
> You have modified the Trusted-Only attribute in the test's MANIFEST.MF 
> file but what about the test code? This test needs some major overhaul.
>
> Regards,
> Jacob

The integration test code should not need changing. ITW uses this 
manifest attribute to decide on whether or not the applet/application 
should be run; the integration tests are just checking whether the 
applet did or did not run in various situations.

-- 
Thanks,

Andrew Azores



More information about the distro-pkg-dev mailing list