[rfc][icedtea-web] fixing typo in trusted-only reproducer
Jiri Vanek
jvanek at redhat.com
Tue Jul 28 08:08:30 UTC 2015
On 07/27/2015 05:53 PM, Jacob Wisor wrote:
> On 07/27/2015 at 05:08 PM Jiri Vanek wrote:
>>
>> -Trusted-only: true
>> +Trusted-Only: true
>>
>> in manifest.. so it was actually testing nothing :-/
>>
>> its here since begining
>> http://icedtea.classpath.org/hg/icedtea-web/annotate/dee18160ba9c/tests/reproducers/custom/TrustedOnlyAttribute/srcs/MANIFEST.MF
>>
>>
>>
>> and more surprising is, that this typo do not affect tests results...
>
> You have modified the Trusted-Only attribute in the test's MANIFEST.MF file but what about the test
> code? This test needs some major overhaul.
As Andrew said, I was completely wrong. And I forgot that manifest attributes are case insensitive.
Thats why the test did not need tuning.
The patch then changed to cosmetic only.
Thanx for eyball!
J.
More information about the distro-pkg-dev
mailing list