[rfc][icedtea-web] change Launcher constructor calling

Andrew Azores aazores at redhat.com
Thu Jun 18 14:51:18 UTC 2015


On 18/06/15 06:46 AM, Jiri Vanek wrote:
> On 06/17/2015 11:45 AM, Jiri Vanek wrote:
>> On 06/16/2015 05:32 PM, Jiri Vanek wrote:
>>> Unluckily the test needed a lot of work, because now the message is 
>>> always posted to queue.
>>>
>>>
>>> Otherwise the patch is pretty straightworward.
>>>
>>> Aslo I have encountered some issues with reprodcuers:
>>>
>>> FAILED: testCaching(AbsolutePathsAndQueryStrings) 
>>> expected:<...ipHttpPathParams.jar[]> but
>>> was:<...ipHttpPathParams.jar[.i_abcd]>
>>>
>>>     - query patch is guilty
>>>
>>> Those three are very suspicious.
>>> FAILED: ReplaceSecurityManagerLunch1(ReplaceSecurityManagerTest) 
>>> ReplaceSecurityManagerLunch1 should
>>> not be terminated, but was
> this one is also - passing again (uuff)
>
>>> FAILED: 
>>> ApplicationJNLPLocalTest(CodeBaseManifestEntrySignedNotMatching) 
>>> should contain `*** APPLET
>>> FINISHED ***`
>>> FAILED: AppletJNLPRLocalTest(CodeBaseManifestEntrySignedNotMatching) 
>>> should contain `*** APPLET
>>> FINISHED ***`
>>>
>>> those three seems to be ths patch related....hmmm
>>> FAILED: testJavawsJNLP - opera(PackGZipTest) stdout should contain 
>>> init, but it didnt.
>>> FAILED: testJavawsJNLP - midori(PackGZipTest) stdout should contain 
>>> init, but it didnt.
>>> FAILED: testJavawsJNLP - epiphany(PackGZipTest) stdout should 
>>> contain init, but it didnt.
> those three are passing again. good:)
>
>>>
>>>
>>> I needed to temrinate testun so I have not run them all. But seem 
>>> sthat soemthing already went wrong
>>> in alst few pushes. (will run them today overnight)
>
> +
> testTrustNoneJnlpAppletLaunch
> testTrustNoneJnlpApplicationLaunch
>
> were brookne by this commit.
>
> some in  AbsolutePathsAndQueryStrings were broken some time ago.
>
>
> and whole CodeBaseManifestEntrySignedNotMatching is now broken.
>
> All should be fixed asap. I willlok to them once I finally review 
> PolicyEditor. As other things I have started are not so 
> intensive-to-be-kept-in-mind.
>
>
>
>
> There is the patch for your EOF.As I told,posted separtely, as I 'm 
> not able to see what everything it may affect.
> J.

Looks alright. Failing tests are worrying as always but I trust you to 
get them fixed :)

-- 
Thanks,

Andrew Azores



More information about the distro-pkg-dev mailing list