[rfc][icedtea-web] remember comemnted out lines in deployment.properties

Jie Kang jkang at redhat.com
Fri May 22 13:00:09 UTC 2015



----- Original Message -----
> Hi!
> 
> Always whern you comment outr something in deployment.properties, then save
> thsoe via itw-settings,
> then those comemnts are gonne. Today my patience with it run ou. THis patch
> is fixing this behaviour.

Hello,

I think this is a good fix :D

First thing that comes to mind though is, can you add tests to verify the new behaviour?


Looking at the code:


+                systemComments=loadComments(systemPropertiesFile);

I don't see systemComments being used anywhere else. Is this intended?


+                comments = comments + "\n" + userComments;

Just curious but, why use "\n" instead of System.lineSeparator()? Not a big deal.


Rest looks okay.


Regards,

> 
> J.
> 

-- 

Jie Kang

Java Team - Software Engineering Intern


More information about the distro-pkg-dev mailing list